Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Scene: Device state trigger can now check that condition was valid for X minutes #2156

Merged
merged 7 commits into from
Nov 8, 2024
Merged

Scene: Device state trigger can now check that condition was valid for X minutes #2156

merged 7 commits into from
Nov 8, 2024

Conversation

Pierre-Gilles
Copy link
Contributor

@Pierre-Gilles Pierre-Gilles commented Nov 4, 2024 •
edited
Loading

Pull Request check-list

To ensure your Pull Request can be accepted as fast as possible, make sure to review and check all of these items:

  • If your changes affects code, did your write the tests?
  • Are tests passing? (npm test on both front/server)
  • Is the linter passing? (npm run eslint on both front/server)
  • Did you run prettier? (npm run prettier on both front/server)
  • If you are adding a new features/services, did you run integration comparator? (npm run compare-translations on front)
  • Did you test this pull request in real life? With real devices? If this development is a big feature or a new service, we recommend that you provide a Docker image to the community (french forum/english forum) for testing before merging.
  • If you are adding a new features/services which needs explanation, did you modify the user documentation? See the GitHub repo and the website.

Description of change

Screenshot 2024-11-04 at 17 19 46

@cloudflare-workers-and-pages Cloudflare Workers and Pages
Copy link

cloudflare-workers-and-pages bot commented Nov 4, 2024 •
edited
Loading

Deploying gladys-plus with  Cloudflare Pages  Cloudflare Pages

Latest commit: 51b221d
Status: ✅  Deploy successful!
Preview URL: https://945fde9b.gladys-plus.pages.dev
Branch Preview URL: https://add-for-duration-in-device-t.gladys-plus.pages.dev

View logs

@relativeci RelativeCI
Copy link

relativeci bot commented Nov 4, 2024 •
edited
Loading

#2857 Bundle Size — 10.26MiB (+0.03%).

51b221d(current) vs 70c64b2 master#2856(baseline)

Warning

Bundle contains 3 duplicate packages – View duplicate packages

Bundle metrics  Change 1 change Regression 1 regression
                 Current
#2857		      Baseline
#2856
Regression  Initial JS 5.56MiB(+0.05%) 5.56MiB
No change  Initial CSS 304.68KiB 304.68KiB
No change  Cache Invalidation 54.06% 54.06%
No change  Chunks 51 51
No change  Assets 171 171
No change  Modules 1495 1495
No change  Duplicate Modules 21 21
No change  Duplicate Code 0.84% 0.84%
No change  Packages 124 124
No change  Duplicate Packages 3 3
Bundle size by type  Change 1 change Regression 1 regression
                 Current
#2857		      Baseline
#2856
Regression  JS 7.35MiB (+0.04%) 7.34MiB
No change  IMG 2.48MiB 2.48MiB
No change  CSS 321.47KiB 321.47KiB
No change  Fonts 93.55KiB 93.55KiB
No change  Other 17.62KiB 17.62KiB
No change  HTML 13.58KiB 13.58KiB

Bundle analysis report Branch add-for-duration-in-device-trigg... Project dashboard

Generated by RelativeCI Documentation Report issue

@codecov Codecov
Copy link

codecov bot commented Nov 4, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.52%. Comparing base (3188ddf) to head (51b221d).
Report is 7 commits behind head on master.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #2156      +/-   ##
==========================================
+ Coverage   98.50%   98.52%   +0.01%     
==========================================
  Files         867      867              
  Lines       14242    14272      +30     
==========================================
+ Hits        14029    14061      +32     
+ Misses        213      211       -2

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Pierre-Gilles Pierre-Gilles merged commit 2540927 into master Nov 8, 2024
10 checks passed
@Pierre-Gilles Pierre-Gilles deleted the add-for-duration-in-device-trigger branch November 8, 2024 16:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@Pierre-Gilles